fix(backup): stop passing deprecated -eula flag to vmbackupmanager#2131
Open
alliasgher wants to merge 1 commit intoVictoriaMetrics:masterfrom
Open
fix(backup): stop passing deprecated -eula flag to vmbackupmanager#2131alliasgher wants to merge 1 commit intoVictoriaMetrics:masterfrom
alliasgher wants to merge 1 commit intoVictoriaMetrics:masterfrom
Conversation
The -eula flag was deprecated in VictoriaMetrics and will be removed, which would cause a startup error in vmbackupmanager. Remove the two places where the operator appended -eula to the container args so that vmbackupmanager starts cleanly on current and future VictoriaMetrics versions. The AcceptEULA field on the CR is left in place for backward compatibility (existing configs that set it will keep working without producing a flag the binary no longer recognises). Fixes VictoriaMetrics#1319 Signed-off-by: alliasgher <alliasgher123@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-eulaflag was deprecated in VictoriaMetrics and will be removed, causing a startup error invmbackupmanageronce that happens. Remove the two places inbuild/backup.gowhere the operator appends-eulato the container args.The
AcceptEULAfield on the CR is intentionally left in place so existing configurations that set it don't require a breaking change.Fixes #1319
Summary by cubic
Stop passing the deprecated
-eulaflag tovmbackupmanagerin backup and restore args so it starts cleanly on current and future VictoriaMetrics versions. TheAcceptEULACR field stays for backward compatibility but no longer changes container args.Written for commit 1cd828d. Summary will update on new commits.